Skip to content

pd.crosstab(s1, s2) keeps dummy MultiIndex as columns if both s1 and s2 have tuple name #18321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
toobaz opened this issue Nov 16, 2017 · 3 comments · Fixed by #30978
Closed
Labels
Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Milestone

Comments

@toobaz
Copy link
Member

toobaz commented Nov 16, 2017

Code Sample, a copy-pastable example if possible

In [2]: s1 = pd.Series(range(3), name=('a', 'b'))

In [3]: s2 = pd.Series(range(3), name=('c', 'd'))

In [4]: pd.crosstab(s1, s2)
Out[4]: 
                   
('c', 'd')  0  1  2
(a, b)             
0           1  0  0
1           0  1  0
2           0  0  1

In [5]: list(pd.crosstab(s1, s2).columns)
Out[5]: [('', 0), ('', 1), ('', 2)]

Problem description

While the example is similar to that reported in #18304, the fix doesn't seem to be related. Reminder: test by expanding the test in #18309 .

Expected Output

In [5]: list(pd.crosstab(s1, s2).columns)
Out[5]: [0, 1, 2]

Output of pd.show_versions()

INSTALLED VERSIONS

commit: 9c799e2
python: 3.5.3.final.0
python-bits: 64
OS: Linux
OS-release: 4.9.0-3-amd64
machine: x86_64
processor:
byteorder: little
LC_ALL: None
LANG: it_IT.UTF-8
LOCALE: it_IT.UTF-8

pandas: 0.22.0.dev0+135.g9c799e2c4
pytest: 3.2.3
pip: 9.0.1
setuptools: 36.7.0
Cython: 0.25.2
numpy: 1.12.1
scipy: 0.19.0
pyarrow: None
xarray: None
IPython: 6.2.1
sphinx: 1.5.6
patsy: 0.4.1
dateutil: 2.6.1
pytz: 2017.2
blosc: None
bottleneck: 1.2.0dev
tables: 3.3.0
numexpr: 2.6.1
feather: 0.3.1
matplotlib: 2.0.0
openpyxl: None
xlrd: 1.0.0
xlwt: 1.1.2
xlsxwriter: 0.9.6
lxml: None
bs4: 4.5.3
html5lib: 0.999999999
sqlalchemy: 1.0.15
pymysql: None
psycopg2: None
jinja2: 2.10
s3fs: None
fastparquet: None
pandas_gbq: None
pandas_datareader: 0.2.1

@sinhrks sinhrks added the Reshaping Concat, Merge/Join, Stack/Unstack, Explode label Nov 16, 2017
@jreback jreback added this to the Next Major Release milestone Dec 29, 2017
@ghost
Copy link

ghost commented Jan 18, 2018

Hi, I want to work on this.

toobaz added a commit to toobaz/pandas that referenced this issue Jan 18, 2018
@toobaz
Copy link
Member Author

toobaz commented Jan 18, 2018

@bluetaxi I had this old branch around:

https://github.com/toobaz/pandas/tree/crosstab_tuple_names

... I didn't push it so I guess it didn't work... but you might want to try the trivial change.

@ghost
Copy link

ghost commented Jan 18, 2018

@toobaz thanks. I'll have a look!

@ghost ghost mentioned this issue Jan 20, 2018
4 tasks
@jreback jreback modified the milestones: Next Major Release, 0.23.0 Jan 23, 2018
@jreback jreback modified the milestones: 0.23.0, Next Major Release Apr 14, 2018
@jreback jreback modified the milestones: Contributions Welcome, 1.1 Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
4 participants