-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Compat for util.testing import #30973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
608f177
Compat for util.testing import
TomAugspurger 92e7163
toplevel
TomAugspurger ade5e71
Merge remote-tracking branch 'upstream/master' into import-util
TomAugspurger e420bbe
toplevel
TomAugspurger c18316f
compat
TomAugspurger fa34e2e
compat
TomAugspurger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,30 @@ | ||
from pandas.util._decorators import Appender, Substitution, cache_readonly # noqa | ||
|
||
from pandas import compat | ||
from pandas.core.util.hashing import hash_array, hash_pandas_object # noqa | ||
|
||
# compatibility for import pandas; pandas.util.testing | ||
|
||
if compat.PY37: | ||
|
||
def __getattr__(name): | ||
if name == "testing": | ||
import pandas.util.testing | ||
|
||
return pandas.util.testing | ||
else: | ||
raise AttributeError(f"module 'pandas.util' has no attribute '{name}'") | ||
|
||
|
||
else: | ||
|
||
class _testing: | ||
def __getattr__(self, item): | ||
import pandas.util.testing | ||
|
||
return getattr(pandas.util.testing, item) | ||
|
||
testing = _testing() | ||
|
||
|
||
del compat |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the future pls put the issue numbers here with a comment to make removals easier.
when this code is read in the future, it will be very hard for anyone not part of the original conversation to grok what is happening here (easily).