Compat for util.testing import #30973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that there's a slight behavior difference across python versions. For |
jorisvandenbossche
approved these changes
Jan 13, 2020
|
LGTM |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 13, 2020
jorisvandenbossche
pushed a commit
that referenced
this pull request
Jan 13, 2020
Co-authored-by: Tom Augspurger <[email protected]>
jreback
reviewed
Jan 14, 2020
| from pandas.core.util.hashing import hash_array, hash_pandas_object # noqa | ||
|
|
||
| # compatibility for import pandas; pandas.util.testing |
There was a problem hiding this comment.
in the future pls put the issue numbers here with a comment to make removals easier.
when this code is read in the future, it will be very hard for anyone not part of the original conversation to grok what is happening here (easily).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30869