Skip to content

DOC: Fix SS03 docstring error #30939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2020
Merged

DOC: Fix SS03 docstring error #30939

merged 1 commit into from
Jan 12, 2020

Conversation

galuhsahid
Copy link
Contributor

Fixes SS03 errors.

None:None:SS03:pandas.DatetimeIndex.freqstr:Summary does not end with a period
None:None:SS03:pandas.PeriodIndex.freqstr:Summary does not end with a period
pandas/pandas/core/window/indexers.py:34:SS03:pandas.api.indexers.BaseIndexer:Summary does not end with a period

Related to #27977, #30733 cc @datapythonista

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

When I ran the script, there are others left, but they might be false positives since I can't find them in the codebase.

datapythonista
datapythonista approved these changes Jan 12, 2020
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks @galuhsahid

@gfyoung gfyoung added this to the 1.1 milestone Jan 12, 2020
@gfyoung gfyoung merged commit 044559a into pandas-dev:master Jan 12, 2020
@gfyoung
Copy link
Member

gfyoung commented Jan 12, 2020

Thanks @galuhsahid !

sthagen added a commit to sthagen/pandas-dev-pandas that referenced this pull request Jan 12, 2020
@sthagen
Merge pull request #5 from pandas-dev/master
d0348b7 
DOC: Fix SS03 docstring error (pandas-dev#30939)
keechongtan added a commit to keechongtan/pandas that referenced this pull request Jan 13, 2020
@keechongtan
Merge remote-tracking branch 'upstream/master' into bug/categorical-i…
4c339ac 
…ndexing-1row-df

* upstream/master: (284 commits)
  CLN: leftover ix checks (pandas-dev#30951)
  CI: numpydev changed double to single quote (pandas-dev#30952)
  DOC: Fix whatsnew contributors section (pandas-dev#30926)
  STY: wrong placed space in strings (pandas-dev#30940)
  TYP: type up parts of series.py (pandas-dev#30761)
  DOC: Fix SS03 docstring error (pandas-dev#30939)
  CLN: remove unnecesary _date_check_type (pandas-dev#30932)
  DOC: Fixture docs in pandas/conftest.py (pandas-dev#30917)
  CLN: F-strings (pandas-dev#30916)
  replace syntax with f-string (pandas-dev#30919)
  BUG: pickle files left behind by tm.round_trip_pickle (pandas-dev#30906)
  TYP: offsets (pandas-dev#30897)
  TYP: typing annotations (pandas-dev#30901)
  WEB: Remove from roadmap moving the docstring script (pandas-dev#30893)
  WEB: Removing Discourse links (pandas-dev#30890)
  DOC: Encourage use of pre-commit in the docs (pandas-dev#30864)
  DEPR: fix missing stacklevel in pandas.core.index deprecation (pandas-dev#30878)
  CLN: remove unnecessary overriding in subclasses (pandas-dev#30875)
  RLS: 1.0.0rc0
  BUG: validate Index data is 1D + deprecate multi-dim indexing (pandas-dev#30588)
  ...

# Conflicts:
#	doc/source/whatsnew/v1.0.0.rst
@galuhsahid galuhsahid mentioned this pull request Jan 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datapythonista datapythonista datapythonista approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@galuhsahid @gfyoung @datapythonista @charlesdong1991