Skip to content

TYP: type up parts of series.py #30761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 12, 2020
Merged

TYP: type up parts of series.py #30761

merged 3 commits into from
Jan 12, 2020

Conversation

topper-123
Copy link
Contributor

More typing.

@pep8speaks
Copy link

pep8speaks commented Jan 6, 2020 •
edited
Loading

Hello @topper-123! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-01-12 13:32:45 UTC

@jreback jreback added the Typing type annotations, mypy/pyright type checking label Jan 6, 2020
@jreback jreback added this to the 1.0 milestone Jan 6, 2020
WillAyd
WillAyd requested changes Jan 7, 2020
View reviewed changes
@topper-123
Copy link
Contributor Author

I think this is the best I can do here: I agree a TypeVar would be best, but it doesn't play well with ._constructor AFAICS.

I wonder if we should deprecate ._constructor and use type(self) for instantiation, but that's probably a different discussion wit its own traps.

@jreback
Copy link
Contributor

jreback commented Jan 9, 2020

lgtm.

@jreback jreback removed this from the 1.0 milestone Jan 9, 2020
@topper-123 topper-123 force-pushed the type_series branch 2 times, most recently from df98e55 to 4ea701a Compare January 9, 2020 18:58
WillAyd
WillAyd approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @simonjayhawkins

@topper-123
Copy link
Contributor Author

ping

simonjayhawkins
simonjayhawkins requested changes Jan 11, 2020
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@topper-123 lgtm ex comment. ping on green.

@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Jan 12, 2020
@simonjayhawkins simonjayhawkins merged commit 28e909c into pandas-dev:master Jan 12, 2020
@simonjayhawkins
Copy link
Member

Thanks @topper-123

@topper-123 topper-123 deleted the type_series branch January 12, 2020 14:55
sthagen added a commit to sthagen/pandas-dev-pandas that referenced this pull request Jan 12, 2020
@sthagen
Merge pull request #6 from pandas-dev/master
767ff5b 
TYP: type up parts of series.py (pandas-dev#30761)
keechongtan added a commit to keechongtan/pandas that referenced this pull request Jan 13, 2020
@keechongtan
Merge remote-tracking branch 'upstream/master' into bug/categorical-i…
4c339ac 
…ndexing-1row-df

* upstream/master: (284 commits)
  CLN: leftover ix checks (pandas-dev#30951)
  CI: numpydev changed double to single quote (pandas-dev#30952)
  DOC: Fix whatsnew contributors section (pandas-dev#30926)
  STY: wrong placed space in strings (pandas-dev#30940)
  TYP: type up parts of series.py (pandas-dev#30761)
  DOC: Fix SS03 docstring error (pandas-dev#30939)
  CLN: remove unnecesary _date_check_type (pandas-dev#30932)
  DOC: Fixture docs in pandas/conftest.py (pandas-dev#30917)
  CLN: F-strings (pandas-dev#30916)
  replace syntax with f-string (pandas-dev#30919)
  BUG: pickle files left behind by tm.round_trip_pickle (pandas-dev#30906)
  TYP: offsets (pandas-dev#30897)
  TYP: typing annotations (pandas-dev#30901)
  WEB: Remove from roadmap moving the docstring script (pandas-dev#30893)
  WEB: Removing Discourse links (pandas-dev#30890)
  DOC: Encourage use of pre-commit in the docs (pandas-dev#30864)
  DEPR: fix missing stacklevel in pandas.core.index deprecation (pandas-dev#30878)
  CLN: remove unnecessary overriding in subclasses (pandas-dev#30875)
  RLS: 1.0.0rc0
  BUG: validate Index data is 1D + deprecate multi-dim indexing (pandas-dev#30588)
  ...

# Conflicts:
#	doc/source/whatsnew/v1.0.0.rst
@topper-123 topper-123 mentioned this pull request Jan 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins requested changes

@WillAyd WillAyd WillAyd approved these changes

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
5 participants
@topper-123 @pep8speaks @jreback @simonjayhawkins @WillAyd