-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
API: no_default #30788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: no_default #30788
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
"""Public API for extending pandas objects.""" | ||
from pandas._libs.lib import _no_default # noqa: F401 | ||
from pandas._libs.lib import no_default # noqa: F401 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we want this available to library authors, but we never want users to use this, right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It should be fine for users. I can imagine people working with the signature of functions that use no_default. |
||
|
||
from pandas.core.dtypes.dtypes import ( # noqa: F401 | ||
ExtensionDtype, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having a cdef version (kind of like we have for NaT) would help perf here (not necessary for this PR)