API: no_default #30788
Merged
API: no_default #30788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm if green |
jbrockmendel
reviewed
Jan 7, 2020
| @@ -2270,7 +2270,7 @@ def map_infer_mask(ndarray arr, object f, const uint8_t[:] mask, bint convert=1, | |||
| result = np.empty(n, dtype=dtype) | |||
| for i in range(n): | |||
| if mask[i]: | |||
| if na_value is _no_default: | |||
| if na_value is no_default: | |||
There was a problem hiding this comment.
having a cdef version (kind of like we have for NaT) would help perf here (not necessary for this PR)
jbrockmendel
reviewed
Jan 7, 2020
| @@ -1,5 +1,5 @@ | |||
| """Public API for extending pandas objects.""" | |||
| from pandas._libs.lib import _no_default # noqa: F401 | |||
| from pandas._libs.lib import no_default # noqa: F401 | |||
There was a problem hiding this comment.
we want this available to library authors, but we never want users to use this, right?
There was a problem hiding this comment.
It should be fine for users. I can imagine people working with the signature of functions that use no_default.
|
Merging since I have a followup depending on this. Will respond more on #30788 (comment) if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes lib._no_default to lib.no_default, uses it in more places.
Closes #30785