BUG: PeriodArray comparisons inconsistent with Period comparisons #30722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
Algos
|
does this slightly change conversion semantics? e.g. the bug part, if so can you add a whatsnew |
|
thanks, IIRC you mentioned that we were going to deprecate comparing * raw strings* to Periods as well? |
no such plans. with this in im planning to share the DTA/TDA/PA comparisons, then fix some inconsistencies in searchsorted (so that DTI/TDI/PI can dispatch to their EAs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second of two non-cosmetic changes mentioned in #30720.