REF: cosmetic differences between DTA/TDA/PA comparison methods #30720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Jan 6, 2020
| @@ -172,6 +177,9 @@ class TimedeltaArray(dtl.DatetimeLikeArrayMixin, dtl.TimelikeOps): | |||
|
|
|||
| _typ = "timedeltaarray" | |||
| _scalar_type = Timedelta | |||
| _recognized_scalars = (timedelta, np.timedelta64, Tick) | |||
There was a problem hiding this comment.
at some point can u add some comments for each of the properties / methods here (and in all the subclasses)
eg it seems obvious was _is_recognized_scalar is now in this PR but best to have some comments
There was a problem hiding this comment.
will comment in the next pass
gfyoung
added
Algos
|
thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 2 remaining non-cosmetic differences between these methods remaining, which will be the subjects of upcoming PRs. Once those are addressed, we'll be able to de-duplicate the methods completely.