IntervalArray equality follow-ups #30715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Thanks @jschendel |
|
@jschendel could IntervalIndex also pass through inequalities to IntervalArray? if so then thats some more code we can share |
|
Yes, although inequalities haven't been implemented yet, even at the scalar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-ups to #30640 based on @jbrockmendel's comments.
Haven't addressed all the comments yet but pushing this up now so there's a record of it.
Changes thus far:
tests/arithmetic/test_interval.pyand moved the tests theremake_wrapped_comparison_opto add__eq__and__ne__toIntervalArray.