-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TYP: Fix chainmap typing for mypy 0.740+ #30680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
note we are currently pinned to 0.73 for a number of issues. |
Yes, I'm aware of them and this a tiny step to get rid of them. |
great that's what I figured, thanks! |
PR looks good to me. There has been a build-in collections.ChainMap since python 3.3. Is this version different or could we switch over to the builtin version? |
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xhochy lgtm. Thanks for the PR.
This will help for 0.73 too... #30539 pandas\compat\chainmap.py:4: error: Implicit generic "Any". Use "typing.ChainMap" and specify generic parameters |
thanks @xhochy |
This will otherwise raise a failure during a
mypy
update. Also increase type precision of this file to 100%.black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
cc @simonjayhawkins