Skip to content

DISC: enable disallow_any_generics for mypy in setup.cfg? #30539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
simonjayhawkins opened this issue Dec 29, 2019 · 1 comment
Open

DISC: enable disallow_any_generics for mypy in setup.cfg? #30539

simonjayhawkins opened this issue Dec 29, 2019 · 1 comment
Labels
CI Continuous Integration Needs Discussion Requires discussion from core team before further action Typing type annotations, mypy/pyright type checking

Comments

@simonjayhawkins
Copy link
Member

This flag disallows usage of generic types that do not specify explicit type parameters. Moreover, built-in collections (such as list and dict) become disallowed as you should use their aliases from the typing module (such as List[int] and Dict[str, str]).

Enabling this would address common pull request review comments. @WillAyd
@simonjayhawkins simonjayhawkins added CI Continuous Integration Typing type annotations, mypy/pyright type checking labels Dec 29, 2019
@simonjayhawkins
Copy link
Member Author

expand to see current list

pandas\compat\chainmap.py:4: error: Implicit generic "Any". Use "typing.ChainMap" and specify generic parameters
pandas\_version.py:50: error: Missing type parameters for generic type "Callable"
pandas\_version.py:53: error: Missing type parameters for generic type "Callable"
pandas\_version.py:54: error: Missing type parameters for generic type "Callable"
pandas\core\dtypes\base.py:137: error: Missing type parameters for generic type "Type"
pandas\util\_test_decorators.py:122: error: Missing type parameters for generic type "Callable"
pandas\util\_test_decorators.py:136: error: Missing type parameters for generic type "Callable"
pandas\util\_test_decorators.py:200: error: Missing type parameters for generic type "Callable"
pandas\util\_test_decorators.py:235: error: Missing type parameters for generic type "Callable"
pandas\io\s3.py:20: error: Missing type parameters for generic type "FilePathOrBuffer"
pandas\io\s3.py:21: error: Missing type parameters for generic type "IO"
pandas\io\s3.py:43: error: Missing type parameters for generic type "FilePathOrBuffer"
pandas\io\s3.py:47: error: Missing type parameters for generic type "IO"
pandas\core\window\numba_.py:12: error: Missing type parameters for generic type "Tuple"
pandas\core\window\numba_.py:84: error: Missing type parameters for generic type "Tuple"
pandas\io\formats\printing.py:97: error: Missing type parameters for generic type "Sequence"
pandas\io\formats\printing.py:132: error: Missing type parameters for generic type "Mapping"
pandas\io\formats\printing.py:282: error: Missing type parameters for generic type "Callable"
pandas\io\formats\printing.py:498: error: Missing type parameters for generic type "Sequence"
pandas\core\dtypes\common.py:205: error: Missing type parameters for generic type "Callable"
pandas\core\dtypes\common.py:210: error: Missing type parameters for generic type "Callable"
pandas\io\common.py:157: error: Missing type parameters for generic type "FilePathOrBuffer"
pandas\io\common.py:272: error: Missing type parameters for generic type "FilePathOrBuffer"
pandas\io\common.py:380: error: Missing type parameters for generic type "IO"
pandas\io\common.py:485: error: Missing type parameters for generic type "FilePathOrBuffer"
pandas\io\common.py:506: error: Missing type parameters for generic type "Iterator"
pandas\io\common.py:519: error: Missing type parameters for generic type "IO"
pandas\io\common.py:543: error: Missing type parameters for generic type "Iterator"
pandas\io\orc.py:15: error: Missing type parameters for generic type "FilePathOrBuffer"
pandas\core\nanops.py:1185: error: Missing type parameters for generic type "Tuple"
pandas\core\common.py:273: error: Missing type parameters for generic type "Iterable"
pandas\core\common.py:273: error: Implicit generic "Any". Use "typing.List" and specify generic parameters
pandas\core\ops\dispatch.py:132: error: Missing type parameters for generic type "Callable"
pandas\core\tools\datetimes.py:66: error: Missing type parameters for generic type "ArrayConvertible"
pandas\core\tools\datetimes.py:187: error: Missing type parameters for generic type "DatetimeScalarOrArrayConvertible"
pandas\core\arrays\datetimelike.py:491: error: Missing type parameters for generic type "Sequence"
pandas\core\strings.py:58: error: Missing type parameters for generic type "List"
pandas\core\strings.py:85: error: Missing type parameters for generic type "List"
pandas\core\indexes\frozen.py:17: error: Implicit generic "Any". Use "typing.List" and specify generic parameters
pandas\core\arrays\string_.py:54: error: Missing type parameters for generic type "Type"
pandas\core\arrays\integer.py:46: error: Missing type parameters for generic type "Type"
pandas\core\arrays\categorical.py:514: error: Implicit generic "Any". Use "typing.List" and specify generic parameters
pandas\core\arrays\boolean.py:75: error: Missing type parameters for generic type "Type"
pandas\core\arrays\sparse\array.py:85: error: Missing type parameters for generic type "Callable"
pandas\core\indexes\multi.py:291: error: Missing type parameters for generic type "List"
pandas\core\indexes\multi.py:313: error: Missing type parameters for generic type "List"
pandas\core\indexes\datetimelike.py:369: error: Missing type parameters for generic type "List"
pandas\plotting\_misc.py:423: error: Implicit generic "Any". Use "typing.Dict" and specify generic parameters
pandas\io\formats\format.py:82: error: Missing type parameters for generic type "Callable"
pandas\io\formats\format.py:84: error: Missing type parameters for generic type "Callable"
pandas\io\formats\format.py:464: error: Missing type parameters for generic type "Callable"
pandas\io\formats\format.py:961: error: Missing type parameters for generic type "List"
pandas\io\formats\format.py:961: error: Missing type parameters for generic type "Tuple"
pandas\io\formats\format.py:1099: error: Missing type parameters for generic type "Callable"
pandas\io\formats\format.py:1180: error: Missing type parameters for generic type "Callable"
pandas\io\formats\format.py:1294: error: Missing type parameters for generic type "Callable"
pandas\io\formats\format.py:1627: error: Missing type parameters for generic type "Callable"
pandas\io\formats\format.py:1690: error: Missing type parameters for generic type "Callable"
pandas\core\indexing.py:223: error: Missing type parameters for generic type "Tuple"
pandas\core\indexing.py:238: error: Missing type parameters for generic type "Tuple"
pandas\core\indexing.py:797: error: Missing type parameters for generic type "Tuple"
pandas\core\indexing.py:820: error: Missing type parameters for generic type "Tuple"
pandas\core\indexing.py:847: error: Missing type parameters for generic type "Tuple"
pandas\core\indexing.py:874: error: Missing type parameters for generic type "Tuple"
pandas\core\indexing.py:891: error: Missing type parameters for generic type "Tuple"
pandas\core\indexing.py:952: error: Missing type parameters for generic type "Tuple"
pandas\core\indexing.py:1297: error: Missing type parameters for generic type "Tuple"
pandas\core\indexing.py:1596: error: Missing type parameters for generic type "Tuple"
pandas\core\indexing.py:1913: error: Missing type parameters for generic type "Tuple"
pandas\core\indexing.py:1962: error: Missing type parameters for generic type "Tuple"
pandas\core\indexing.py:2227: error: Implicit generic "Any". Use "typing.Tuple" and specify generic parameters
pandas\core\generic.py:2153: error: Missing type parameters for generic type "FilePathOrBuffer"
pandas\core\generic.py:3009: error: Missing type parameters for generic type "FilePathOrBuffer"
pandas\core\generic.py:3514: error: Missing type parameters for generic type "Callable"
pandas\core\series.py:594: error: Missing type parameters for generic type "Callable"
pandas\core\frame.py:410: error: Missing type parameters for generic type "Axes"
pandas\core\frame.py:411: error: Missing type parameters for generic type "Axes"
pandas\core\frame.py:4751: error: Missing type parameters for generic type "Iterable"
pandas\core\frame.py:6043: error: Missing type parameters for generic type "Tuple"
pandas\io\parsers.py:417: error: Missing type parameters for generic type "FilePathOrBuffer"
pandas\io\parsers.py:704: error: Missing type parameters for generic type "FilePathOrBuffer"
pandas\io\parsers.py:786: error: Missing type parameters for generic type "Iterator"
pandas\io\parsers.py:3540: error: Missing type parameters for generic type "Iterator"
pandas\core\groupby\grouper.py:422: error: Implicit generic "Any". Use "typing.Dict" and specify generic parameters
pandas\core\groupby\groupby.py:1113: error: Missing type parameters for generic type "Type"
pandas\core\groupby\groupby.py:1121: error: Missing type parameters for generic type "Type"
pandas\core\groupby\groupby.py:1881: error: Missing type parameters for generic type "Type"
pandas\core\groupby\groupby.py:1896: error: Missing type parameters for generic type "Type"
pandas\core\groupby\generic.py:1122: error: Missing type parameters for generic type "OrderedDict"
pandas\core\groupby\generic.py:1139: error: Missing type parameters for generic type "OrderedDict"
pandas\core\groupby\generic.py:1465: error: Missing type parameters for generic type "Callable"
pandas\io\excel\_openpyxl.py:476: error: Missing type parameters for generic type "FilePathOrBuffer"
pandas\io\excel\_openpyxl.py:493: error: Missing type parameters for generic type "FilePathOrBuffer"
pandas\io\stata.py:1013: error: Missing type parameters for generic type "Iterator"
pandas\io\pytables.py:1187: error: Missing type parameters for generic type "Dict"
pandas\io\pytables.py:1239: error: Missing type parameters for generic type "List"
pandas\io\pytables.py:1462: error: Implicit generic "Any". Use "typing.List" and specify generic parameters
pandas\io\pytables.py:3143: error: Missing type parameters for generic type "List"
pandas\io\pytables.py:3144: error: Missing type parameters for generic type "List"
pandas\io\pytables.py:3145: error: Missing type parameters for generic type "Dict"
pandas\io\pytables.py:3706: error: Missing type parameters for generic type "List"
pandas\io\json\_normalize.py:113: error: Missing type parameters for generic type "Dict"
pandas\io\json\_normalize.py:114: error: Missing type parameters for generic type "List"
pandas\io\json\_normalize.py:115: error: Missing type parameters for generic type "List"
pandas\io\json\_normalize.py:271: error: Missing type parameters for generic type "List"
pandas\io\json\_normalize.py:274: error: Missing type parameters for generic type "DefaultDict"
pandas\io\json\_json.py:612: error: Missing type parameters for generic type "Iterator"
pandas\core\reshape\pivot.py:569: error: Missing type parameters for generic type "Dict"
pandas\core\reshape\pivot.py:620: error: Missing type parameters for generic type "Callable"
pandas\core\reshape\concat.py:504: error: Missing type parameters for generic type "List"
pandas\util\testing.py:2126: error: Implicit generic "Any". Use "typing.Dict" and specify generic parameters
pandas\io\sas\sas_xport.py:254: error: Missing type parameters for generic type "Iterator"
pandas\io\sas\sas7bdat.py:40: error: Missing type parameters for generic type "Iterator"
pandas\io\formats\style.py:137: error: Missing type parameters for generic type "Callable"
pandas\io\formats\style.py:137: error: Missing type parameters for generic type "Tuple"
pandas\io\formats\style.py:137: error: Missing type parameters for generic type "Dict"
pandas\io\formats\html.py:83: error: Missing type parameters for generic type "Iterable"
pandas\io\formats\html.py:141: error: Missing type parameters for generic type "Dict"
pandas\io\formats\html.py:166: error: Missing type parameters for generic type "Iterable"
pandas\io\excel\_odfreader.py:21: error: Missing type parameters for generic type "FilePathOrBuffer"
pandas\io\excel\_odfreader.py:31: error: Missing type parameters for generic type "FilePathOrBuffer"
pandas\core\window\common.py:67: error: Missing type parameters for generic type "Callable"
pandas\core\window\rolling.py:96: error: Missing type parameters for generic type "Callable"
pandas\core\window\rolling.py:200: error: Missing type parameters for generic type "Dict"
pandas\core\window\rolling.py:397: error: Missing type parameters for generic type "Callable"
pandas\core\window\rolling.py:417: error: Missing type parameters for generic type "Callable"
pandas\core\window\rolling.py:441: error: Missing type parameters for generic type "Callable"
pandas\core\window\rolling.py:982: error: Missing type parameters for generic type "Dict"
pandas\core\window\rolling.py:982: error: Missing type parameters for generic type "Tuple"
pandas\core\window\rolling.py:1027: error: Missing type parameters for generic type "Tuple"
pandas\core\window\rolling.py:1055: error: Missing type parameters for generic type "Callable"
pandas\core\window\rolling.py:1056: error: Missing type parameters for generic type "Callable"
pandas\core\window\rolling.py:1299: error: Missing type parameters for generic type "Dict"
pandas\core\window\rolling.py:1300: error: Missing type parameters for generic type "Tuple"
pandas\core\window\rolling.py:1301: error: Missing type parameters for generic type "Dict"
pandas\tests\indexing\test_coercion.py:930: error: Missing type parameters for generic type "List"
pandas\tests\frame\methods\test_replace.py:15: error: Implicit generic "Any". Use "typing.List" and specify generic parameters
pandas\tests\frame\methods\test_replace.py:20: error: Implicit generic "Any". Use "typing.List" and specify generic parameters
pandas\tests\dtypes\test_common.py:293: error: Missing type parameters for generic type "List"
pandas\tests\dtypes\test_common.py:325: error: Missing type parameters for generic type "List"
pandas\tests\dtypes\test_common.py:361: error: Missing type parameters for generic type "List"
Found 141 errors in 52 files (checked 838 source files)

@simonjayhawkins simonjayhawkins mentioned this issue Dec 29, 2019
Merged
@simonjayhawkins simonjayhawkins added the Needs Discussion Requires discussion from core team before further action label Dec 30, 2019
This was referenced Dec 31, 2019
Merged
Merged
Merged
Merged
@simonjayhawkins simonjayhawkins changed the title DISC: enable disallow_any_generics for mypy in setup.cfg? DISC: enable disallow_any_generic for mypy in setup.cfg? Jan 28, 2020
@simonjayhawkins simonjayhawkins mentioned this issue Jan 28, 2020
Merged
5 tasks
@simonjayhawkins simonjayhawkins mentioned this issue Jul 8, 2020
Merged
@simonjayhawkins simonjayhawkins added this to the Contributions Welcome milestone Jul 8, 2020
@simonjayhawkins simonjayhawkins mentioned this issue Aug 5, 2020
Merged
3 tasks
@simonjayhawkins simonjayhawkins mentioned this issue Sep 9, 2020
Merged
5 tasks
@simonjayhawkins simonjayhawkins mentioned this issue Oct 14, 2020
Merged
3 tasks
@simonjayhawkins simonjayhawkins mentioned this issue Mar 14, 2021
Merged
@jbrockmendel jbrockmendel changed the title DISC: enable disallow_any_generic for mypy in setup.cfg? DISC: enable disallow_any_generics for mypy in setup.cfg? Mar 14, 2021
@simonjayhawkins simonjayhawkins mentioned this issue Apr 1, 2021
Merged
@mroeschke mroeschke removed this from the Contributions Welcome milestone Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous Integration Needs Discussion Requires discussion from core team before further action Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mroeschke @simonjayhawkins