Skip to content

CLN: remove unnecessary scipy attr checks #30450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 24, 2019
Merged

CLN: remove unnecessary scipy attr checks #30450

merged 1 commit into from
Dec 24, 2019

Conversation

jbrockmendel
Copy link
Member

akima and pchip have existed since at least scipy 0.14, and we require 1.1, so these checks are unnecessary.

@WillAyd WillAyd added the Clean label Dec 24, 2019
WillAyd
WillAyd approved these changes Dec 24, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if green

@WillAyd WillAyd added this to the 1.0 milestone Dec 24, 2019
@WillAyd WillAyd merged commit 1f991e5 into pandas-dev:master Dec 24, 2019
@WillAyd
Copy link
Member

WillAyd commented Dec 24, 2019

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the pchip branch December 24, 2019 21:18
AlexKirko pushed a commit to AlexKirko/pandas that referenced this pull request Dec 29, 2019
@jbrockmendel @AlexKirko
CLN: remove unnecessary scipy attr checks (pandas-dev#30450)
9919d55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

DEPS: possibly unnecessary scipy function checks
2 participants
@jbrockmendel @WillAyd