Skip to content

DEPS: possibly unnecessary scipy function checks #30383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbrockmendel opened this issue Dec 20, 2019 · 0 comments · Fixed by #30450
Closed

DEPS: possibly unnecessary scipy function checks #30383

jbrockmendel opened this issue Dec 20, 2019 · 0 comments · Fixed by #30450
Labels
Dependencies Required and optional dependencies

Comments

@jbrockmendel
Copy link
Member

I'm seeing in test some things like

    try:
        from scipy.interpolate import pchip_interpolate  # noqa
    except ImportError:
        import pytest

        pytest.skip("scipy.interpolate.pchip missing")


def _skip_if_no_akima():
    try:
        from scipy.interpolate import Akima1DInterpolator  # noqa
    except ImportError:
        import pytest

        pytest.skip("scipy.interpolate.Akima1DInterpolator missing")

AFAICT pchip_interpolate goes back to at least scipy 0.13.0, and we require 0.19.0, so this check should be unnecessary (or more accurately, replaced with a skip_if_no_scipy). Not sure about akima, but we should track these down and put them all into test_decorators or compat or something

@jbrockmendel jbrockmendel added the Dependencies Required and optional dependencies label Dec 21, 2019
@jbrockmendel jbrockmendel changed the title COMPAT: possibly unnecessary scipy function checks DEPS: possibly unnecessary scipy function checks Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant