Skip to content

WIP/ DOC: Move 'For Developers' content from wiki to contributing docs. #30232 #30406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

souvik3333
Copy link
Contributor

No description provided.

@souvik3333 souvik3333 changed the title WIP/ DOC: Move 'For Developers' content from wiki to contributing docs. (#30232) WIP/ DOC: Move 'For Developers' content from wiki to contributing docs. #30232 Dec 22, 2019
@gfyoung gfyoung added the Docs label Dec 22, 2019
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a noticeable amount of Python 2 discussion here, even though we don't support Python 2 anymore in the codebase.

Can you explain why you added so much content about Python 2 compatibility?

@datapythonista
Copy link
Member

Thanks @souvik3333, I think moving things from the wiki here is a good idea, but looks like the page you moved is not relevant anymore, now that we don't support Python 2.

Closing, but we should remove the page from the wiki (I don't have permissions, or may be it's just that it's not possible in the mobile version).

@souvik3333
Copy link
Contributor Author

souvik3333 commented Dec 22, 2019

Can you explain why you added so much content about Python 2 compatibility?

I was working on issue #30232 and this content was mentioned there. @gfyoung @datapythonista Can you verify the other content of the list in the issue description?

@alimcmaster1
Copy link
Member

#30410 @souvik3333 there is some discussion going on about it here

@souvik3333
Copy link
Contributor Author

#30410 @souvik3333 there is some discussion going on about it here

Yes, I just found it. Thank you.

@simonjayhawkins
Copy link
Member

Thanks @souvik3333, I think moving things from the wiki here is a good idea, but looks like the page you moved is not relevant anymore, now that we don't support Python 2.

I think we want the Imports (aim for absolute) section and maybe more.

Need to import ``parse_date`` from ``compat`` to handle versions of dateutil that don't
play nice with unicode.

Imports (aim for absolute)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove all but this section. (retain as subsection of Code Standards)

Comment on lines +657 to +658
# may FAIL in Python 3
import common
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could remove this

It's important to write code that will be compatible with most recent version of
Python 3.

Python 2/3 Compatibility
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only py3.6+ is supported, so I think we can remove this too

@simonjayhawkins
Copy link
Member

@souvik3333 I think the additions here should be added to doc/source/development/contributing_code_guide.rst once #30129 is merged

@datapythonista
Copy link
Member

Closing this, since all the Python 2/3 documentation is not useful anymore. @souvik3333 as said, once #30129 is merged, you can add a section about the imports there. Thanks!

@souvik3333 souvik3333 deleted the contributing-doc-update branch January 13, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants