-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
WIP/ DOC: Move 'For Developers' content from wiki to contributing docs. #30232 #30406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a noticeable amount of Python 2 discussion here, even though we don't support Python 2 anymore in the codebase.
Can you explain why you added so much content about Python 2 compatibility?
Thanks @souvik3333, I think moving things from the wiki here is a good idea, but looks like the page you moved is not relevant anymore, now that we don't support Python 2. Closing, but we should remove the page from the wiki (I don't have permissions, or may be it's just that it's not possible in the mobile version). |
I was working on issue #30232 and this content was mentioned there. @gfyoung @datapythonista Can you verify the other content of the list in the issue description? |
#30410 @souvik3333 there is some discussion going on about it here |
Yes, I just found it. Thank you. |
I think we want the |
Need to import ``parse_date`` from ``compat`` to handle versions of dateutil that don't | ||
play nice with unicode. | ||
|
||
Imports (aim for absolute) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can remove all but this section. (retain as subsection of Code Standards)
# may FAIL in Python 3 | ||
import common |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could remove this
It's important to write code that will be compatible with most recent version of | ||
Python 3. | ||
|
||
Python 2/3 Compatibility |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only py3.6+ is supported, so I think we can remove this too
@souvik3333 I think the additions here should be added to doc/source/development/contributing_code_guide.rst once #30129 is merged |
Closing this, since all the Python 2/3 documentation is not useful anymore. @souvik3333 as said, once #30129 is merged, you can add a section about the imports there. Thanks! |
No description provided.