Skip to content

ERR: stringify error message from parsers.pyx, closes #29233 #30246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 13, 2019
Merged

ERR: stringify error message from parsers.pyx, closes #29233 #30246

merged 3 commits into from
Dec 13, 2019

Conversation

jbrockmendel
Copy link
Member

@simonjayhawkins simonjayhawkins added Error Reporting Incorrect or improved errors from pandas IO CSV read_csv, to_csv labels Dec 12, 2019
simonjayhawkins
simonjayhawkins reviewed Dec 12, 2019
View reviewed changes
pandas/tests/io/parser/test_common.py Outdated
try:
pd.read_csv("nonexistent_name")
except FileNotFoundError as err:
assert err.strerror == "File nonexistent_name does not exist"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can pytest.raises not be used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea. i think this was split off from a branch where i was also checking err.errno

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also looks like theres another test i can merge this into

simonjayhawkins
simonjayhawkins approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbrockmendel lgtm

@simonjayhawkins simonjayhawkins added this to the 1.0 milestone Dec 13, 2019
@jreback jreback merged commit 665e4b1 into pandas-dev:master Dec 13, 2019
@jreback
Copy link
Contributor

jreback commented Dec 13, 2019

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the errs-io branch December 13, 2019 15:29
@Ynob2000 Ynob2000 mentioned this pull request Dec 18, 2019
Merged
5 tasks
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel @proost
ERR: stringify error message from parsers.pyx, closes pandas-dev#29233 (
4370308 
pandas-dev#30246)
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@jbrockmendel @proost
ERR: stringify error message from parsers.pyx, closes pandas-dev#29233 (
3311ee3 
pandas-dev#30246)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

Assignees
No one assigned
Labels
Error Reporting Incorrect or improved errors from pandas IO CSV read_csv, to_csv
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

read_csv encode operation on source
3 participants
@jbrockmendel @jreback @simonjayhawkins