Groupby agg works with pd.Series.nunique, but groupby nunique fails with axis=1 #30311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to Tom for the tip Co-Authored-By: Tom Augspurger <[email protected]>
I still need to merge with master for CI issues
|
PR has been updated accordingly to your remarks |
TomAugspurger
approved these changes
Dec 18, 2019
WillAyd
approved these changes
Dec 18, 2019
|
Great thanks @nlepleux ! |
jreback
reviewed
Dec 19, 2019
| @@ -1813,9 +1813,20 @@ def groupby_series(obj, col=None): | |||
| # Try to consolidate with normal wrapping functions | |||
| from pandas.core.reshape.concat import concat | |||
|
|
|||
| results = [groupby_series(content, label) for label, content in obj.items()] | |||
| axis_number = obj._get_axis_number(self.axis) | |||
There was a problem hiding this comment.
@WillAyd this is adding quite a bit of very hard and bespoke code
pls don’t merge non trivial things like this
this is also likely non performant
pls revert
|
What performance are you looking for from the axis=1 case? Wonder if time is better spent optimizing that than reverting
…Sent from my iPhone
On Dec 18, 2019, at 4:17 PM, Jeff Reback ***@***.***> wrote:
@jreback commented on this pull request.
In pandas/core/groupby/generic.py:
> @@ -1813,9 +1813,20 @@ def groupby_series(obj, col=None):
# Try to consolidate with normal wrapping functions
from pandas.core.reshape.concat import concat
- results = [groupby_series(content, label) for label, content in obj.items()]
+ axis_number = obj._get_axis_number(self.axis)
@WillAyd this is adding quite a bit of very hard and bespoke code
pls don’t merge non trivial things like this
this is also likely non performant
pls revert
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
i am way more concerned about the code smell this introduces |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
AlexKirko
pushed a commit
to AlexKirko/pandas
that referenced
this pull request
Dec 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff