Skip to content

CLN: Split test_base #30130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2019
Merged

CLN: Split test_base #30130

merged 1 commit into from
Dec 8, 2019

Conversation

SaturnFromTitan
Copy link
Contributor

part of #23877

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

Some notes:

  • test_ops.py still feels pretty bloated, but I didn't see a good opportunity for further splitting
  • test_conversion.py is testing things like to_list and to_numpy. Maybe there's a better name for the file

@alimcmaster1 alimcmaster1 added Clean Testing pandas testing functions or related to the test suite labels Dec 7, 2019
WillAyd
WillAyd approved these changes Dec 8, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Would definitely take follow up PRs to fixturize these instead of relying on the Ops base class setup method

@SaturnFromTitan
Copy link
Contributor Author

Yes, I will definitely do that

@jreback jreback added this to the 1.0 milestone Dec 8, 2019
@jreback jreback merged commit 989a415 into pandas-dev:master Dec 8, 2019
@jreback
Copy link
Contributor

jreback commented Dec 8, 2019

thanks @SaturnFromTitan nice split on this, keep em coming!

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@SaturnFromTitan @proost
split test_base into multiple files (pandas-dev#30130)
6806124
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@SaturnFromTitan @proost
split test_base into multiple files (pandas-dev#30130)
422e917
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@SaturnFromTitan @jreback @WillAyd @alimcmaster1