CLN: Make non-empty **kwargs in Index.__new__ fail instead of silently dropped #29625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
changed the title
topper-123
commented
Nov 14, 2019
pandas/core/indexes/base.py
Outdated
| @@ -4259,7 +4266,8 @@ def _concat_same_dtype(self, to_concat, name): | |||
| Concatenate to_concat which has the same class. | |||
| """ | |||
| # must be overridden in specific classes | |||
| klasses = (ABCDatetimeIndex, ABCTimedeltaIndex, ABCPeriodIndex, ExtensionArray) | |||
| klasses = (ABCDatetimeIndex, ABCTimedeltaIndex, ABCPeriodIndex, ExtensionArray, | |||
| ABCIntervalIndex) | |||
There was a problem hiding this comment.
Without this, if the first element is a IntervalIndex, a"side" parameter is passed to _shallow_copy_with_infer ind the call will fail.
topper-123
commented
Nov 14, 2019
| ) | ||
| tm.assert_index_equal(result, expected) | ||
|
|
||
| result = pd.Index(index, names=["A", "B"]) | ||
| result = pd.Index(index, name="A") |
There was a problem hiding this comment.
Both result and expected are normal Index instances and instantiating with a names parameter should fail.
topper-123
force-pushed
the
Index._simple_kwargs
branch
3 times, most recently
from
2942d5e to
af7b800
Compare
topper-123
force-pushed
the
Index._simple_kwargs
branch
from
af7b800 to
ac76102
Compare
jreback
requested changes
Nov 16, 2019
pandas/core/indexes/base.py
Outdated
| if len(kwargs) == 1: | ||
| msg = f"Unexpected keyword argument {list(kwargs)[0]!r}" | ||
| else: | ||
| msg = f"Unexpected keyword arguments {set(kwargs)!r}" |
There was a problem hiding this comment.
I would just use this one (the set), no need to make a super-detailed error message
jreback
approved these changes
Nov 16, 2019
|
lgtm. merge on green. |
topper-123
force-pushed
the
Index._simple_kwargs
branch
from
30219fc to
d2cd11e
Compare
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #29624 I made change so random kwargs weren't passed to
Index._simple_new. I'v found out after merging that the selected solution dropped non-empty kwargs, which isn't great either.This version ensures that passing non-accepted kwargs raises, so
pd.Index(['a'], foo="foo")raises a TypeError. Instead of raising a TypeError, should we deprecate adding non-accepted kwargs?