Skip to content

Commit 30219fc

Browse files
committed
simpler error message
1 parent ac76102 commit 30219fc

File tree

5 files changed

+5
-9
lines changed

5 files changed

+5
-9
lines changed

pandas/core/indexes/base.py

+1-5
Original file line numberDiff line numberDiff line change
@@ -452,11 +452,7 @@ def __new__(
452452
except IncompatibleFrequency:
453453
pass
454454
if kwargs:
455-
if len(kwargs) == 1:
456-
msg = f"Unexpected keyword argument {list(kwargs)[0]!r}"
457-
else:
458-
msg = f"Unexpected keyword arguments {set(kwargs)!r}"
459-
raise TypeError(msg)
455+
raise TypeError(f"Unexpected keyword arguments {set(kwargs)!r}")
460456
return cls._simple_new(subarr, name, **kwargs)
461457

462458
elif hasattr(data, "__array__"):

pandas/tests/indexes/multi/test_equivalence.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ def test_identical(idx):
146146
assert mi.identical(mi2)
147147

148148
mi3 = Index(mi.tolist(), names=mi.names)
149-
msg = r"Unexpected keyword argument 'names'"
149+
msg = r"Unexpected keyword argument {'names'}"
150150
with pytest.raises(TypeError, match=msg):
151151
Index(mi.tolist(), names=mi.names, tupleize_cols=False)
152152
mi4 = Index(mi.tolist(), tupleize_cols=False)

pandas/tests/indexes/test_base.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ def test_constructor_simple_new(self, vals, dtype):
352352

353353
def test_constructor_wrong_kwargs(self):
354354
# GH #19348
355-
with pytest.raises(TypeError, match="Unexpected keyword argument 'foo'"):
355+
with pytest.raises(TypeError, match="Unexpected keyword argument {'foo'}"):
356356
Index([], foo="bar")
357357

358358
@pytest.mark.parametrize(

pandas/tests/indexing/test_coercion.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -490,7 +490,7 @@ def test_insert_index_period(self, insert, coerced_val, coerced_dtype):
490490
exp = pd.PeriodIndex(data, freq="M")
491491
self._assert_insert_conversion(obj, insert, exp, coerced_dtype)
492492
else:
493-
msg = r"Unexpected keyword argument 'freq'"
493+
msg = r"Unexpected keyword argument {'freq'}"
494494
with pytest.raises(TypeError, match=msg):
495495
pd.Index(data, freq="M")
496496

pandas/tests/io/excel/test_readers.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -893,7 +893,7 @@ def test_excel_passes_na_filter(self, read_ext, na_filter):
893893
def test_unexpected_kwargs_raises(self, read_ext, arg):
894894
# gh-17964
895895
kwarg = {arg: "Sheet1"}
896-
msg = "unexpected keyword argument `{}`".format(arg)
896+
msg = fr"unexpected keyword argument {{{arg}}}"
897897

898898
with pd.ExcelFile("test1" + read_ext) as excel:
899899
with pytest.raises(TypeError, match=msg):

0 commit comments

Comments
 (0)