CLN: remove kwargs from Index._simple_new #29604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice |
| def difference(self, other, sort=None): | ||
| new_idx = super().difference(other, sort=sort) | ||
| new_idx.freq = None | ||
| return new_idx |
There was a problem hiding this comment.
could this be shared in one of the datetimelike classes?
There was a problem hiding this comment.
I don't think so: PeriodIndex doesn't allow freq=None and DatetimeIndexOpsMixin is shared with that`. Don't know if that's a bug in PeriodIndex or as intended, as I haven't worked much with datetime objects.
My motivation with this is getting kwargs out of a basic method and make child classes just build on that using super + the specific stuff. That is easier to reason about IMO.
| @@ -464,6 +464,11 @@ def _convert_for_op(self, value): | |||
| return _to_M8(value) | |||
| raise ValueError("Passed item and index have different timezone") | |||
|
|
|||
| def difference(self, other, sort=None): | |||
There was a problem hiding this comment.
Can you add a docstring here? (I think you can use one of the decorators to append Index.difference.__doc__)
(and same below)
topper-123
force-pushed
the
Index._simple_new_kwargs
branch
from
fe28788 to
2109eae
Compare
jorisvandenbossche
approved these changes
Nov 14, 2019
jreback
approved these changes
Nov 14, 2019
|
lgtm. merge on green. |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes kwargs from
Index._simple_new.The kwargs are actually ony used by
DateTimeIndex.differenceandTimeDeltaIndex.difference.