Skip to content

Commit 6a5c860

Browse files
authored
CLN: remove kwargs from Index._simple_new (#29604)
1 parent 8ad5c12 commit 6a5c860

File tree

4 files changed

+17
-9
lines changed

4 files changed

+17
-9
lines changed

pandas/core/indexes/base.py

+3-4
Original file line numberDiff line numberDiff line change
@@ -506,7 +506,7 @@ def asi8(self):
506506
return None
507507

508508
@classmethod
509-
def _simple_new(cls, values, name=None, dtype=None, **kwargs):
509+
def _simple_new(cls, values, name=None, dtype=None):
510510
"""
511511
We require that we have a dtype compat for the values. If we are passed
512512
a non-dtype compat, then coerce using the constructor.
@@ -528,8 +528,7 @@ def _simple_new(cls, values, name=None, dtype=None, **kwargs):
528528
# we actually set this value too.
529529
result._index_data = values
530530
result.name = name
531-
for k, v in kwargs.items():
532-
setattr(result, k, v)
531+
533532
return result._reset_identity()
534533

535534
@cache_readonly
@@ -2673,7 +2672,7 @@ def difference(self, other, sort=None):
26732672
except TypeError:
26742673
pass
26752674

2676-
return this._shallow_copy(the_diff, name=result_name, freq=None)
2675+
return this._shallow_copy(the_diff, name=result_name)
26772676

26782677
def symmetric_difference(self, other, result_name=None, sort=None):
26792678
"""

pandas/core/indexes/datetimes.py

+6
Original file line numberDiff line numberDiff line change
@@ -464,6 +464,12 @@ def _convert_for_op(self, value):
464464
return _to_M8(value)
465465
raise ValueError("Passed item and index have different timezone")
466466

467+
@Appender(Index.difference.__doc__)
468+
def difference(self, other, sort=None):
469+
new_idx = super().difference(other, sort=sort)
470+
new_idx.freq = None
471+
return new_idx
472+
467473
# --------------------------------------------------------------------
468474
# Rendering Methods
469475

pandas/core/indexes/range.py

+2-5
Original file line numberDiff line numberDiff line change
@@ -146,21 +146,18 @@ def from_range(cls, data, name=None, dtype=None):
146146
return cls._simple_new(data, dtype=dtype, name=name)
147147

148148
@classmethod
149-
def _simple_new(cls, values, name=None, dtype=None, **kwargs):
149+
def _simple_new(cls, values, name=None, dtype=None):
150150
result = object.__new__(cls)
151151

152152
# handle passed None, non-integers
153153
if values is None:
154154
# empty
155155
values = range(0, 0, 1)
156156
elif not isinstance(values, range):
157-
return Index(values, dtype=dtype, name=name, **kwargs)
157+
return Index(values, dtype=dtype, name=name)
158158

159159
result._range = values
160-
161160
result.name = name
162-
for k, v in kwargs.items():
163-
setattr(result, k, v)
164161

165162
result._reset_identity()
166163
return result

pandas/core/indexes/timedeltas.py

+6
Original file line numberDiff line numberDiff line change
@@ -406,6 +406,12 @@ def intersection(self, other, sort=False):
406406
"""
407407
return super().intersection(other, sort=sort)
408408

409+
@Appender(Index.difference.__doc__)
410+
def difference(self, other, sort=None):
411+
new_idx = super().difference(other, sort=sort)
412+
new_idx.freq = None
413+
return new_idx
414+
409415
def _wrap_joined_index(self, joined, other):
410416
name = get_op_result_name(self, other)
411417
if (

0 commit comments

Comments
 (0)