TYP: annotate _data #29580
Merged
TYP: annotate _data #29580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. @simonjayhawkins @WillAyd |
WillAyd
reviewed
Nov 13, 2019
| @@ -78,7 +78,7 @@ class DatetimeIndexOpsMixin(ExtensionOpsMixin): | |||
| common ops mixin to support a unified interface datetimelike Index | |||
| """ | |||
|
|
|||
| _data = None | |||
There was a problem hiding this comment.
Were these solely set to None before for annotation purposes? I think need to be careful in changing this if the intent was not solely for that purpose
There was a problem hiding this comment.
these were here pre-annotations, so I think it was so that the attribute always exists
jorisvandenbossche
approved these changes
Nov 13, 2019
| @@ -230,7 +230,7 @@ def _outer_indexer(self, left, right): | |||
| return libjoin.outer_join_indexer(left, right) | |||
|
|
|||
| _typ = "index" | |||
| _data = None | |||
| _data: Union[ExtensionArray, np.ndarray] | |||
There was a problem hiding this comment.
you can now remove the assert and comment added in #29475 on L657?
|
thanks @jbrockmendel |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB: this does induce a small behavior change in that
Indexwill not have a_dataattribute until__init__/__new__.I found in #29561 that getting
_dataannotated is necessary before we can annotate most ofcore.indexes.I'm also not sure what to do about MultiIndex, suggestions welcome.