Skip to content

TYPES: __len__, is_all_dates, inferred_type #29475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 11, 2019

Conversation

jbrockmendel
Copy link
Member

Operation Get This Over With, part 2

Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbrockmendel lgtm. just the one comment. or remove hints from this method for now.

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Nov 8, 2019
@simonjayhawkins simonjayhawkins added this to the 1.0 milestone Nov 8, 2019
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbrockmendel . Thanks for the update. lgtm. @WillAyd

@jbrockmendel
Copy link
Member Author

@WillAyd gentle ping

@WillAyd WillAyd merged commit 5c36aa1 into pandas-dev:master Nov 11, 2019
@WillAyd
Copy link
Member

WillAyd commented Nov 11, 2019

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the cln-index1 branch November 11, 2019 23:11
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants