Disallow non-scalar fill_value in maybe_upcast #29362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ybe_upcast_nomask
…ybe_upcast_nomask
jbrockmendel
changed the title
jreback
added
Dtype Conversions
|
this is orthogonal to #29331 ? |
jreback
requested changes
Nov 2, 2019
correct
for maybe_upcast_putmask i dont think so. for Block.shift maybe; im still a little iffy on the object-dtype case there |
jreback
approved these changes
Nov 4, 2019
|
thanks, pls followon tests as needed |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with #29331 and #29332 this allows us to rule out non-scalar fill_value being passed to maybe_promote for almost all cases, the last few of which we'll have to address individually.
The restriction in
Block.shiftcould be an API change if you squint and tilt your head.The assertion in masked_rec_array_to_mgr is based on my read of the numpy docs, but it'd be worth double-checking.