REF: implement maybe_promote_scalar #29331
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Nov 2, 2019
| return maybe_promote_scalar(dtype, fill_value) | ||
|
|
||
|
|
||
| def maybe_promote_scalar(dtype, fill_value=np.nan): |
There was a problem hiding this comment.
can you add a doc-string / types
There was a problem hiding this comment.
added docstring, annotations i need to coordinate with others about implementing correct types in pd._typing
jreback
approved these changes
Nov 2, 2019
|
lgtm. ping on green. |
|
ping |
|
gentle ping. we're getting close to being done with the maybe_promote saga |
|
Unnecessary following #29416, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Narrowing down the set of cases where we have to worry about a non-scalar fill_value. I'm pretty sure we can narrow it down further, but saving that for a separate step as it has some complications for EA corner cases.
cc @jreback