REF: Pre-empt TypeError in groupby #29261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was this |
The |
jreback
requested changes
Oct 29, 2019
| if ( | ||
| f_name not in base.plotting_methods | ||
| sdata = splitter._get_sorted_data() | ||
| if sdata.ndim == 2 and np.any(sdata.dtypes.apply(is_extension_array_dtype)): |
There was a problem hiding this comment.
I would move this to the Splittler class something like
@cache_only
def has_extension_array(self):
return self.data.dtypes.apply(...)
and can handle this on Series & Frame splitter
There was a problem hiding this comment.
yah, this function is definitely getting refactored in a later pass. id like to get the exceptions sorted out before trying to decide about the refactor
jreback
approved these changes
Nov 2, 2019
|
k looks fine (hopefully you have followons!). rebase and ping on green. |
|
ping |
|
Thanks @jbrockmendel |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @WillAyd @jreback, should be orthogonal to #29228.