CLN: prevent libreduction TypeError #29228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Oct 25, 2019
| @@ -641,12 +641,15 @@ def curried(x): | |||
| # if we don't have this method to indicated to aggregate to | |||
| # mark this column as an error | |||
| try: | |||
| return self._aggregate_item_by_item(name, *args, **kwargs) | |||
| result = self._aggregate_item_by_item(name, *args, **kwargs) | |||
There was a problem hiding this comment.
Can we just replace this function altogether with _python_agg_general? Conceptually it would seem like they do the same thing, though the former would actually be generic across Series and DataFrame
There was a problem hiding this comment.
I haven't checked specifically, but I'm hoping we can trim these before long
|
thanks @jbrockmendel |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jreback @WillAyd