Skip to content

Replace _has_complex_internals #29227 #29237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 14, 2019

Conversation

Aivengoe
Copy link
Contributor

@Aivengoe Aivengoe commented Oct 26, 2019

closes #29227

Hi, it my first issues within hacktoberfest.
I replaced _has_complex_internals with isinstance/
Is it possible to import ABCMultiIndex?

@jbrockmendel
Copy link
Member

You're going to need to run isort -rc pandas to fix the linting errors. In the reduction.pyx we don't allow imports from core, so the check will need to be something like index.nlevels > 1

@simonjayhawkins simonjayhawkins changed the title Replace _has_coplex_internals #29227 Replace _has_complex_internals #29227 Oct 26, 2019
@jreback
Copy link
Contributor

jreback commented Oct 29, 2019

also pls merge master, we just update the codebase with another small usage of this (which needs to be changed)

@jbrockmendel
Copy link
Member

pushed rebased and isort fixup

@jreback
Copy link
Contributor

jreback commented Nov 13, 2019

@jbrockmendel this needed or did you already remove?

@jbrockmendel
Copy link
Member

still needed

@jreback
Copy link
Contributor

jreback commented Nov 14, 2019

ok @Aivengoe can you merge master.

@jbrockmendel feel free to push here if its faster

@jreback jreback added this to the 1.0 milestone Nov 14, 2019
@jreback jreback merged commit 2bf5ce7 into pandas-dev:master Nov 14, 2019
@jreback
Copy link
Contributor

jreback commented Nov 14, 2019

thanks @Aivengoe and @jbrockmendel

Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace _has_complex_internals with isinstance(..., ABCMultiIndex)
4 participants