Skip to content

Replace _has_complex_internals with isinstance(..., ABCMultiIndex) #29227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
WillAyd opened this issue Oct 25, 2019 · 0 comments · Fixed by #29237
Closed

Replace _has_complex_internals with isinstance(..., ABCMultiIndex) #29227

WillAyd opened this issue Oct 25, 2019 · 0 comments · Fixed by #29237
Labels
Clean
Milestone
1.0.0

Comments

@WillAyd
Copy link
Member

WillAyd commented Oct 25, 2019

I've stumbled across this code a few times in groupby and it took me a while to grasp. I'm pretty sure this always evaluates to False, unless we are dealing with a MultiIndex.

For code clarity, I think it would be better if we just did an isinstance check as I don't think the intent of _has_complex_internals is very clear
@WillAyd WillAyd added the Clean label Oct 25, 2019
Aivengoe added a commit to Aivengoe/pandas that referenced this issue Oct 26, 2019
@Aivengoe
Replace _has_coplex_internals pandas-dev#29227
0559c6a
@Aivengoe Aivengoe mentioned this issue Oct 26, 2019
Merged
jbrockmendel pushed a commit to Aivengoe/pandas that referenced this issue Nov 12, 2019
@Aivengoe @jbrockmendel
Replace _has_coplex_internals pandas-dev#29227
a3a4c7e
jreback pushed a commit that referenced this issue Nov 14, 2019
@Aivengoe @jreback
Replace _has_complex_internals #29227 (#29237)
2bf5ce7
@jreback jreback added this to the 1.0 milestone Nov 14, 2019
Reksbril pushed a commit to Reksbril/pandas that referenced this issue Nov 18, 2019
@Aivengoe
Replace _has_complex_internals pandas-dev#29227 (pandas-dev#29237)
e027d8d
proost pushed a commit to proost/pandas that referenced this issue Dec 19, 2019
@Aivengoe @proost
Replace _has_complex_internals pandas-dev#29227 (pandas-dev#29237)
63a4032
proost pushed a commit to proost/pandas that referenced this issue Dec 19, 2019
@Aivengoe @proost
Replace _has_complex_internals pandas-dev#29227 (pandas-dev#29237)
f2bf351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Replace _has_complex_internals #29227 Aivengoe/pandas
2 participants
@WillAyd @jreback