-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: Add StringArray.__arrow_array__ for conversion to Arrow #29182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -182,6 +182,16 @@ def _from_sequence(cls, scalars, dtype=None, copy=False): | |
def _from_sequence_of_strings(cls, strings, dtype=None, copy=False): | ||
return cls._from_sequence(strings, dtype=dtype, copy=copy) | ||
|
||
def __arrow_array__(self, type=None): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. shouldn't we make a new base EA mixin class for this? e.g. this is pretty generic code There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and have String/Integer array use this? (maybe actually just put in the EA base class itself?) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For now, this one is different than the one in IntegerArray, so it cannot directly be shared with that. I thought about putting this in the PandasArray class, but the StringArray is the only subclass of it that is actually used. So therefore I kept it here. But open to other options. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
That's not possible, because it depends on the internals (eg StringArray uses There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok cool. yeah this can certainly be handled in a followup; but i think we DO want to generally enable these types of conversions. |
||
""" | ||
Convert myself into a pyarrow Array. | ||
""" | ||
import pyarrow as pa | ||
|
||
if type is None: | ||
type = pa.string() | ||
return pa.array(self._ndarray, type=type, from_pandas=True) | ||
|
||
def __setitem__(self, key, value): | ||
value = extract_array(value, extract_numpy=True) | ||
if isinstance(value, type(self)): | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maya have an extra parenthesis here.