-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TYPING: lockdown test modules passing mypy #28914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TYPING: lockdown test modules passing mypy #28914
Conversation
Are some of these easy to fix? Would be nice to keep the setup.cfg small if could do as precursors |
maybe, not really looked in detail. and I personally won't be prioritising this over the main codebase. it was so others, could add type hints to the tests and have them checked(well most of them) see #28904 also if doing it on a per module basis, easier to confirm in review if the module is also removed from setup.cfg (process adopted for check_untyped_defs, seems to work well) |
Sounds good. No major objection from me - @jreback any thoughts? |
not at desktop atm. will give you a better idea of the workload tomorrow. i think it was about 200 errors. but many duplicates. and some files might only have a couple. I think if the extra noise in setup.cfg is an issue, we could consider using mypy.ini |
didn’t we use mypy.ini as some point? i guess that’s better |
Yea went from mypy.ini to setup.cfg in #27427 - I don't know if there are any real nuances to going back so would be OK with that |
ok, yeah let's keep in the same |
FYI xref #28910 now that this is on master, a mypy bump to 0.730 would break ci
PR coming soon. just parking here for reference. |
xref #28904 (comment) and #28746 (comment)