clean tests/indexing/common.py #28904
Merged
+38
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
force-pushed
the
clean_indexing_common
branch
from
e083475 to
fcffdff
Compare
pandas/tests/indexing/common.py
Outdated
| import itertools | ||
| from typing import Dict, Hashable, Union |
There was a problem hiding this comment.
@topper-123 we have ignore_errors=True for pandas.tests.* in setup.cfg
so I am -1 on adding types that aren't checked. If not correct could be more confusing.
I am not against adding types to the tests, but we need to enable the reporting of errors first IMO.
There was a problem hiding this comment.
I didn't know that, makes sense that type checking should be turned on before we use type hints. I'll remove the type hints.
I'm also +1 for adding type checking on for tests; they do make it easier to understand what you're looking at.
simonjayhawkins
added
Clean
Testing
|
thanks @topper-123 |
jreback
added
the
Indexing
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean-up of tests/indexing/common.py.