DOC: fix PR09,PR08 errors for pandas.Timestamp #28739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datapythonista
approved these changes
Oct 2, 2019
|
lgtm as well, though maybe @jbrockmendel can confirm intent on deprecated argument |
jbrockmendel
reviewed
Oct 2, 2019
jbrockmendel
reviewed
Oct 2, 2019
jbrockmendel
reviewed
Oct 2, 2019
jbrockmendel
reviewed
Oct 2, 2019
|
Couple of nitpicks, all of which can be follow-ups if preferred. Otherwise LGTM. |
|
@jbrockmendel a few open questions in my responses |
|
I think the ValueError edit needs tot be reverted and we need an opinion from datapythonista on a long set of literals. Once those two are addressed, LGTM. |
added 3 commits
October 4, 2019 00:01
this also involves editing the NaT type class and Timedelta class. this is because there is a validation which enforces all of these classes to have the same docstrings closes pandas-dev#28673
based on pr feedback
josibake
force-pushed
the
docstrings-pr09-pr08-timestamp-fix
branch
from
2f844ab to
1c583a5
Compare
|
Thanks @josibake |
galuhsahid
added a commit
to galuhsahid/pandas
that referenced
this pull request
Oct 4, 2019
* master: (22 commits) DOC: fix PR09,PR08 errors for pandas.Timestamp (pandas-dev#28739) WEB: Add diversity note to team.md (pandas-dev#28630) DOC: Minor fixes in pandas/testing.py docstring. (pandas-dev#28752) TST: port maybe_promote tests from pandas-dev#23982 (pandas-dev#28764) Bugfix/groupby datetime issue (pandas-dev#28569) reenable codecov (pandas-dev#28750) CLN: Centralised _check_percentile (pandas-dev#27584) DEPR: Deprecate Index.set_value (pandas-dev#28621) CLN: Fix typo in contributing.rst (pandas-dev#28761) Fixed docstring errors in pandas.period range and pandas.PeriodIndex (pandas-dev#28756) BUG: Fix TypeError raised in libreduction (pandas-dev#28643) DOC: Pandas.Series.drop docstring PR02 (pandas-dev#27976) (pandas-dev#28742) DOC: Fixed doctring errors PR08, PR09 in pandas.io (pandas-dev#28748) TST: Fix broken test cases where Timedelta/Timestamp raise (pandas-dev#28729) REF: Consolidate alignment calls in DataFrame ops (pandas-dev#28638) BUG: Fix dep generation (pandas-dev#28734) Added doctstring to fixture (pandas-dev#28727) DOC: Fixed PR06 docstrings errors in pandas.timedelta_range (pandas-dev#28719) replaced safe_import with a corresponding test decorator (pandas-dev#28731) BUG: Fix RangeIndex.get_indexer for decreasing RangeIndex (pandas-dev#28680) ...
2 tasks
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alright, trying this again.
Note: for
Timestamp.tz_localize, thedeprecated:: 0.24.0was in the wrong place. the indentation implied it was only deprecating thecoerceargument of theerrorsparameter, but if you read both of the arguments forerrors, it implies the entire parameter is deprecated in favor ofnonexistent(added in 0.24.0)Regarding the length of this PR, it also involved editing the NaT type class and Timedelta class. This is because there is a validation which enforces all of these classes to have the same docstrings.