DOC: fix DataFrame.plot docstrings errors PR09,PR08 #28781
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is related to pandas-dev#28702 also fix a few formatting issues related to default arguments and argument ordering
josibake
changed the title
WillAyd
approved these changes
Oct 4, 2019
following the convention for long lists of known values braces following the convention for multi type arguments
datapythonista
approved these changes
Oct 7, 2019
There was a problem hiding this comment.
looks good, thanks for the fixes @josibake
Can you just merge master, so we can merge with green CI please?
|
@josibake do you mind merging master and fixing the conflicts. This is ready to be merged when you do. Thanks! |
|
@josibake looks about ready, can you rebase |
|
@josibake pls rebase |
|
Closing as stale. Feel free to re-open if you want to continue here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is related to #28702
also fix a few formatting issues
related to default arguments
and argument ordering
black pandas