ENH: Allow plotting backend to be an option #28622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm I haven't added any docs. I suppose there should at least be a mention in the docstring. |
jorisvandenbossche
changed the title
|
I think this is ready. |
jsignell
force-pushed
the
backend_option
branch
from
d241e09 to
2199210
Compare
|
@jsignell can you rebase |
Co-Authored-By: Tom Augspurger <[email protected]>
jsignell
force-pushed
the
backend_option
branch
from
2199210 to
0a7800b
Compare
jsignell
commented
Oct 28, 2019
pandas/plotting/_core.py
Outdated
| ... return_type=None) | ||
| >>> type(boxplot) | ||
| <class 'numpy.ndarray'> | ||
| """ |
There was a problem hiding this comment.
I'd like not to duplicate this, but I couldn't figure out a good way to inject the backend argument doc string.
There was a problem hiding this comment.
Just to clarify: this is because boxplot doesn't accept a backend argument right?
I may have a fix, will push it up if that works.
|
|
||
| If ``return_type`` is `None`, a NumPy array | ||
| of axes with the same shape as ``layout`` is returned. | ||
| %(backend)s\ |
There was a problem hiding this comment.
This is the only really new thing. Otherwise it's just a move from being written in boxplot to using Appender.
TomAugspurger
approved these changes
Nov 5, 2019
datapythonista
approved these changes
Nov 5, 2019
|
Thanks @jsignell! |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
* Allow backend to be an option
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
* Allow backend to be an option
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
* Allow backend to be an option
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.plot()#28619black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff