-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: add plotting backends in visualization.rst #31066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rushabh-v
commented
Jan 16, 2020
•
edited
Loading
edited
- closes DOC: plotting backend is not mentioned in the user guide #30984
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, well explain, thanks for the work on this.
There is just one thing I don't see clear. I think we may be adding content for two different audiences here. I think in the visualization user guide it makes sense to explain that other plotting backends exist, and how to use them. But I think the last part is not for pandas users, but for developers of pandas extensions. I think this should be in the Development
documentation. We can surely link from the user guide there, but I don't think a "regular" pandas users cares about how to define entry points in setup.py
. Does that make sense?
Yes, what this PR is adding is meant for users, the development part already exists: https://dev.pandas.io/docs/development/extending.html#plotting-backends. See also my first review comment to remove this part here in the PR (and replace it with a link, what you said :-)) |
Saw the other comments but missed that one. Agree with all points. :) |
Can you review this PR, please? |
thanks, @jorisvandenbossche for those corrections. The linting is clear now. |
does it require any change now? |
Thanks! |