Skip to content

DOC: add plotting backends in visualization.rst #31066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 5, 2020

Conversation

rushabh-v
Copy link
Contributor

@rushabh-v rushabh-v commented Jan 16, 2020

@WillAyd
Copy link
Member

WillAyd commented Jan 16, 2020

@jorisvandenbossche

@jorisvandenbossche jorisvandenbossche changed the title add plotting backends in visualization.rst DOC: add plotting backends in visualization.rst Jan 16, 2020
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, well explain, thanks for the work on this.

There is just one thing I don't see clear. I think we may be adding content for two different audiences here. I think in the visualization user guide it makes sense to explain that other plotting backends exist, and how to use them. But I think the last part is not for pandas users, but for developers of pandas extensions. I think this should be in the Development documentation. We can surely link from the user guide there, but I don't think a "regular" pandas users cares about how to define entry points in setup.py. Does that make sense?

@jorisvandenbossche
Copy link
Member

There is just one thing I don't see clear. I think we may be adding content for two different audiences here. I think in the visualization user guide it makes sense to explain that other plotting backends exist, and how to use them. But I think the last part is not for pandas users, but for developers of pandas extensions. I think this should be in the Development documentation.

Yes, what this PR is adding is meant for users, the development part already exists: https://dev.pandas.io/docs/development/extending.html#plotting-backends. See also my first review comment to remove this part here in the PR (and replace it with a link, what you said :-))

@datapythonista
Copy link
Member

datapythonista commented Jan 16, 2020

Saw the other comments but missed that one. Agree with all points. :)

@rushabh-v rushabh-v requested review from jorisvandenbossche and datapythonista and removed request for datapythonista January 17, 2020 15:23
@rushabh-v
Copy link
Contributor Author

Can you review this PR, please?

@rushabh-v
Copy link
Contributor Author

thanks, @jorisvandenbossche for those corrections. The linting is clear now.

@rushabh-v
Copy link
Contributor Author

does it require any change now?

@jorisvandenbossche jorisvandenbossche merged commit cc4a3e9 into pandas-dev:master Feb 5, 2020
@jorisvandenbossche
Copy link
Member

Thanks!

@jorisvandenbossche jorisvandenbossche added this to the 1.1 milestone Feb 5, 2020
@rushabh-v rushabh-v deleted the vis-doc branch February 5, 2020 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: plotting backend is not mentioned in the user guide
5 participants