BUG: wrong exception raised by Week+Day #28530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense to me. Can you add a whatsnew for 1.0.0? |
TomAugspurger
approved these changes
Sep 19, 2019
Is this something we need to test more generally? |
|
Probably not. Just had reports from them in the past. |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
* BUG: Week+Day raising wrong exception * whatsnew
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
* BUG: Week+Day raising wrong exception * whatsnew
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With that fixed, we can clean up an Exception in tseries.frequencies.