BUG: wrong exception raised by Week+Day (#28530)

* BUG: Week+Day raising wrong exception

* whatsnew

Author: jbrockmendel

doc/source/whatsnew/v1.0.0.rst

@@ -149,7 +149,7 @@ Datetimelike
 - Bug in :class:`Timestamp` subtraction when subtracting a :class:`Timestamp` from a ``np.datetime64`` object incorrectly raising ``TypeError`` (:issue:`28286`)
 - Addition and subtraction of integer or integer-dtype arrays with :class:`Timestamp` will now raise ``NullFrequencyError`` instead of ``ValueError`` (:issue:`28268`)
 - Bug in :class:`Series` and :class:`DataFrame` with integer dtype failing to raise ``TypeError`` when adding or subtracting a ``np.datetime64`` object (:issue:`28080`)
--
+- Bug in :class:`Week` with ``weekday`` incorrectly raising ``AttributeError`` instead of ``TypeError`` when adding or subtracting an invalid type (:issue:`28530`)
 
 
 Timedelta

pandas/tests/tseries/offsets/test_offsets.py

@@ -4348,3 +4348,12 @@ def test_last_week_of_month_on_offset():
     slow = (ts + offset) - offset == ts
     fast = offset.onOffset(ts)
     assert fast == slow
+
+
+def test_week_add_invalid():
+    # Week with weekday should raise TypeError and _not_ AttributeError
+    #  when adding invalid offset
+    offset = Week(weekday=1)
+    other = Day()
+    with pytest.raises(TypeError, match="Cannot add"):
+        offset + other

pandas/tseries/frequencies.py

@@ -138,7 +138,7 @@ def to_offset(freq):
                         delta = offset
                     else:
                         delta = delta + offset
-        except Exception:
+        except ValueError:
             raise ValueError(libfreqs.INVALID_FREQ_ERR_MSG.format(freq))
 
     else:
@@ -170,7 +170,7 @@ def to_offset(freq):
                     delta = offset
                 else:
                     delta = delta + offset
-        except Exception:
+        except (ValueError, TypeError):
             raise ValueError(libfreqs.INVALID_FREQ_ERR_MSG.format(freq))
 
     if delta is None:

pandas/tseries/offsets.py

@@ -605,7 +605,7 @@ def apply(self, other):
             return BDay(self.n, offset=self.offset + other, normalize=self.normalize)
         else:
             raise ApplyTypeError(
-                "Only know how to combine business day with " "datetime or timedelta."
+                "Only know how to combine business day with datetime or timedelta."
             )
 
     @apply_index_wraps
@@ -1545,6 +1545,13 @@ def apply(self, other):
         if self.weekday is None:
             return other + self.n * self._inc
 
+        if not isinstance(other, datetime):
+            raise TypeError(
+                "Cannot add {typ} to {cls}".format(
+                    typ=type(other).__name__, cls=type(self).__name__
+                )
+            )
+
         k = self.n
         otherDay = other.weekday()
         if otherDay != self.weekday: