Skip to content

Change conda channel order for Windows builds #28357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 11, 2019
Merged

Change conda channel order for Windows builds #28357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbb588c
Change conda channel order for Windows builds
xhochy Sep 9, 2019
1e101f2
XFail on pyarrow 0.14
xhochy Sep 11, 2019
84f95fe
XFail for 0.13 too
xhochy Sep 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ci/deps/azure-windows-36.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
name: pandas-dev
channels:
- defaults
- conda-forge
- defaults
dependencies:
- blosc
- bottleneck
- boost-cpp<1.67
- fastparquet>=0.2.1
- matplotlib=3.0.2
- numexpr
- numpy=1.15.*
- openpyxl
- parquet-cpp
- pyarrow
- pytables
- python-dateutil
Expand Down
10 changes: 10 additions & 0 deletions pandas/tests/io/test_parquet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
""" test parquet compat """
import datetime
from distutils.version import LooseVersion
import os
from warnings import catch_warnings

Expand Down Expand Up @@ -238,6 +239,15 @@ def test_cross_engine_pa_fp(df_cross_compat, pa, fp):
def test_cross_engine_fp_pa(df_cross_compat, pa, fp):
# cross-compat with differing reading/writing engines

if (
LooseVersion(pyarrow.__version__) < "0.15"
and LooseVersion(pyarrow.__version__) >= "0.13"
):
pytest.xfail(
"Reading fastparquet with pyarrow in 0.14 fails: "
"https://issues.apache.org/jira/browse/ARROW-6492"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle this also depends on the fastparquet version, but probably easier to just skip it altogether like you do. It might that this fails on 0.13 as well, not sure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was failing for 0.13 too and I've added this to the XFail.

)

df = df_cross_compat
with tm.ensure_clean() as path:
df.to_parquet(path, engine=fp, compression=None)
Expand Down