Skip to content

Change conda channel order for Windows builds #28357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 11, 2019
Merged

Change conda channel order for Windows builds #28357

merged 3 commits into from
Sep 11, 2019

Conversation

xhochy
Copy link
Contributor

@xhochy xhochy commented Sep 9, 2019 •
edited
Loading

@gfyoung gfyoung added CI Continuous Integration Windows Windows OS labels Sep 9, 2019
@WillAyd
Copy link
Member

WillAyd commented Sep 9, 2019

Do we also need the channel_priority as part of the config?

https://conda-forge.org/docs/user/tipsandtricks.html#how-to-fix-it

@jorisvandenbossche
Copy link
Member

@xhochy the failure you get in test_cross_engine_fp_pa is a known issue (if you have combination of latest released versions of both pyarrow and fastparquet; apparently this is a combination we were not yet testing?) and should be fixed in the upcoming pyarrow release (https://issues.apache.org/jira/browse/ARROW-6492)

@xhochy
Copy link
Contributor Author

xhochy commented Sep 11, 2019

Do we also need the channel_priority as part of the config?

https://conda-forge.org/docs/user/tipsandtricks.html#how-to-fix-it

No, we shouldn't need it as it is the default in conda 4.7.

@xhochy
Copy link
Contributor Author

xhochy commented Sep 11, 2019

@xhochy the failure you get in test_cross_engine_fp_pa is a known issue (if you have combination of latest released versions of both pyarrow and fastparquet; apparently this is a combination we were not yet testing?) and should be fixed in the upcoming pyarrow release (https://issues.apache.org/jira/browse/ARROW-6492)

Cool, that saves me from looking into this. What should I do to work around this? xfail for pyarrow==0.14.x?

Also is this is change worth a whatsnew entry?

@jorisvandenbossche
Copy link
Member

Cool, that saves me from looking into this. What should I do to work around this? xfail for pyarrow==0.14.x?

Yes, something like that

Also is this is change worth a whatsnew entry?

Not need if you are OK with that ;)

jorisvandenbossche
jorisvandenbossche reviewed Sep 11, 2019
View reviewed changes
pandas/tests/io/test_parquet.py
if pyarrow.__version__.startswith("0.14"):
pytest.xfail(
"Reading fastparquet with pyarrow in 0.14 fails: "
"https://issues.apache.org/jira/browse/ARROW-6492"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle this also depends on the fastparquet version, but probably easier to just skip it altogether like you do. It might that this fails on 0.13 as well, not sure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was failing for 0.13 too and I've added this to the XFail.

@TomAugspurger
Copy link
Contributor

Looks good (doc build failure is unrelated).

@xhochy I think you'll need to remove the WIP flag.

@xhochy xhochy marked this pull request as ready for review September 11, 2019 15:56
@xhochy
Copy link
Contributor Author

xhochy commented Sep 11, 2019

@TomAugspurger Done.

@jorisvandenbossche
Copy link
Member

The docs failure is indeed unrelated (problem with downloading from url)

@jorisvandenbossche jorisvandenbossche merged commit 9bb82b3 into pandas-dev:master Sep 11, 2019
@jorisvandenbossche
Copy link
Member

Thanks @xhochy !

@jorisvandenbossche jorisvandenbossche added this to the 1.0 milestone Sep 11, 2019
@jorisvandenbossche jorisvandenbossche mentioned this pull request Sep 26, 2019
Merged
@jorisvandenbossche
Copy link
Member

@meeseeksdev backport to 0.25.x

@meeseeksmachine meeseeksmachine mentioned this pull request Sep 26, 2019
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Sep 26, 2019
@xhochy
Backport PR pandas-dev#28357: Change conda channel order for Windows …
a721f1e 
…builds
jorisvandenbossche pushed a commit that referenced this pull request Sep 26, 2019
@meeseeksmachine @jorisvandenbossche
Backport PR #28357: Change conda channel order for Windows builds (#2…
f6207e0 
…8627)
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@xhochy @proost
CI: Change conda channel order for Windows builds (pandas-dev#28357)
096b1bc
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@xhochy @proost
CI: Change conda channel order for Windows builds (pandas-dev#28357)
34fa6e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration Windows Windows OS
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Conda channels are in wrong order in Windows Tests on Azure
5 participants
@xhochy @WillAyd @jorisvandenbossche @TomAugspurger @gfyoung