Improved benchmark coverage for reading spreadsheets #28230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
added
Benchmark
- Added comment in environment.yml - Added conda-forge to asv config - Refactored reader benchmark
WillAyd
reviewed
Aug 30, 2019
| writer_write = ExcelWriter(bio_write, engine=engine) | ||
| self.df.to_excel(writer_write, sheet_name="Sheet1") | ||
| writer_write.save() | ||
| bio = BytesIO() |
There was a problem hiding this comment.
Any reason for changing this? I think self-contained
There was a problem hiding this comment.
The naming was obsolete. Before the PR, all the setup was done in one function for both read and write benchmarks. Hence the variable names having postfixes _read and _write were justified, but not anymore, I guess?
This comment has been minimized.
This comment has been minimized.
|
If you run |
WillAyd
reviewed
Sep 3, 2019
There was a problem hiding this comment.
I think this looks good. Any chance you can post the results?
@mroeschke who may also have ideas
asv_bench/benchmarks/io/excel.py
Outdated
| doc.spreadsheet.addElement(table) | ||
| doc.save(self.fname_odf) | ||
|
|
||
| def setup(self, engine): |
There was a problem hiding this comment.
Do you know how much time the setup process here takes? Wonder if this should be setup_cache instead to get any write times out of the read benchmark
There was a problem hiding this comment.
Was north of 1 second, but not more than 1.2, I think. I've replaced setup with setup_cache. Makes much more sense, of course.
WillAyd
reviewed
Sep 3, 2019
mroeschke
reviewed
Sep 3, 2019
|
This is the output: |
|
Thanks for the help! @WillAyd @mroeschke |
|
Great! Thanks @f6v |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
* Improved benchmark coverage for reading spreadsheets * Added blank lines * More blank lines * Updated whatsnew * - Removed whatsnew entry - Added comment in environment.yml - Added conda-forge to asv config - Refactored reader benchmark * Updated requirements-dev.txt * Fixed imports order * Fixed imports again * Run black * Changed conda channels order in ASV config * Used setup_cache to speed up read benchmark
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
* Improved benchmark coverage for reading spreadsheets * Added blank lines * More blank lines * Updated whatsnew * - Removed whatsnew entry - Added comment in environment.yml - Added conda-forge to asv config - Refactored reader benchmark * Updated requirements-dev.txt * Fixed imports order * Fixed imports again * Run black * Changed conda channels order in ASV config * Used setup_cache to speed up read benchmark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffAFAIK there's no writer for OpenDocument spreadsheet, so I came up with the minimal amount of code to generate the spreadsheet
odfengine can read.