Skip to content

ASV Benchmark for read_excel #27485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
WillAyd opened this issue Jul 19, 2019 · 3 comments · Fixed by #28230
Closed

ASV Benchmark for read_excel #27485

WillAyd opened this issue Jul 19, 2019 · 3 comments · Fixed by #28230
Labels
Benchmark Performance (ASV) benchmarks good first issue IO Excel read_excel, to_excel

Comments

@WillAyd
Copy link
Member

WillAyd commented Jul 19, 2019

Right now we don't benchmark performance of read_excel across the various engines (xlrd, openpyxl and odfpy) so would gladly accept contributions to improve benchmark coverage on those
@WillAyd WillAyd added IO Excel read_excel, to_excel good first issue Benchmark Performance (ASV) benchmarks labels Jul 19, 2019
@WillAyd WillAyd added this to the Contributions Welcome milestone Jul 19, 2019
@sameshl
Copy link
Contributor

sameshl commented Jul 20, 2019

@WillAyd I would like to work on this.
Correct me if I am wrong but aren't we doing exactly that by seeing this code ?

@WillAyd
Copy link
Member Author

WillAyd commented Jul 20, 2019

We don't actually parametrize read_excel in those benchmarks so they run continuously for xlrd. Need to leverage the parametrization by at a minimum doing engine=engine in the read_excel test, but then also may need to account for the various file formats

@f6v
Copy link
Contributor

f6v commented Aug 30, 2019 •
edited
Loading

@WillAyd could you take a look at the PR please?

@f6v f6v mentioned this issue Aug 30, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Benchmark Performance (ASV) benchmarks good first issue IO Excel read_excel, to_excel
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improved benchmark coverage for reading spreadsheets f6v/pandas
3 participants
@WillAyd @f6v @sameshl