TST: fix flaky xfail #28016
Merged
TST: fix flaky xfail #28016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
| def test_drop_duplicates_categorical_non_bool(self, dtype, ordered_fixture): | ||
| cat_array = np.array([1, 2, 3, 4, 5], dtype=np.dtype(dtype)) | ||
|
|
||
| # Test case 1 | ||
| input1 = np.array([1, 2, 3, 3], dtype=np.dtype(dtype)) | ||
| tc1 = Series(Categorical(input1, categories=cat_array, ordered=ordered_fixture)) | ||
| if dtype == "datetime64[D]": | ||
| # pre-empty flaky xfail, tc1 values are seemingly-random |
There was a problem hiding this comment.
Huh, I can't say that I understand why this would be.
There was a problem hiding this comment.
in _recode_for_categories we're going through an ensure_object path and problems crop up around then. I'm not sure exactly why, but I think the solution will involve casting from datetime64[D] to datetime64[ns] without going through object
|
SGTM. #27715 was backported, so we'll backport this as well. |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 19, 2019
EunSeop
pushed a commit
to EunSeop/pandas
that referenced
this pull request
Aug 20, 2019
* TST: fix flaky xfail
jorisvandenbossche
pushed a commit
that referenced
this pull request
Aug 20, 2019
galuhsahid
pushed a commit
to galuhsahid/pandas
that referenced
this pull request
Aug 25, 2019
* TST: fix flaky xfail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xfail in more specific circumstance
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff