TST: troubleshoot inconsistent xfails #27715
Conversation
|
Thanks for taking a look at these - great to get these working again. Took a quick look at a couple builds and noticed they weren't always the same failures. Could split this up into a few PRs if easier to troubleshoot |
|
Hello @jbrockmendel! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-08-02 23:33:25 UTC |
|
black and flake8 are OK with this diff, pep8speaks must have its own config or a version mismatch? |
|
@WillAyd can I get a "booyah"? |
|
booyah it is |
jbrockmendel
changed the title
| @@ -666,6 +666,7 @@ def test_comparison_tzawareness_compat_scalars(self, op, box_with_array): | |||
| # Raising in __eq__ will fallback to NumPy, which warns, fails, | |||
| # then re-raises the original exception. So we just need to ignore. | |||
| @pytest.mark.filterwarnings("ignore:elementwise comp:DeprecationWarning") | |||
| @pytest.mark.filterwarnings("ignore:Converting timezone-aware:FutureWarning") | |||
There was a problem hiding this comment.
same question as on another PR, is this hiding something?
There was a problem hiding this comment.
AFAICT just noise in the logs
|
any reason we shouldn't do this for 0.25.1? |
Not that I'm aware of |
|
thanks @jbrockmendel |
No description provided.