BUG: Ensure that fill_na in Categorical only replaces null values #27932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
changed the title
pandas/tests/series/test_missing.py
Outdated
| ], | ||
| ) | ||
| def test_fillna_categorical_with_new_categories( | ||
| self, new_categories, fill_value, expected_output |
There was a problem hiding this comment.
Why do you need new_categories at all? Can you not create the series with categories=['a', 'b', 'c', 'd', 'e']?
Can you add a test where the original series and the fill_value series have the same categories, but in different order?
s = pd.Series(pd.Categorical(['a', None, 'b'], categories=['b', 'c', 'a']))
s.fillna(pd.Series(pd.Categorical(['a', 'c', 'a'], categories=['c', 'a', 'b']))…e fill value series values are in different order
MarcoGorelli
force-pushed
the
categorical-fillna
branch
from
ad111b6 to
e088eab
Compare
|
Can you add the test from #27932 (comment)? We've had issues in the past with unordered categories where the categories / codes didn't line up. |
…er to categories of origin series
|
Sure :) I've added a test where the fill value is a series with the same categories as the original series but in a different order, sorry for having missed this the first time |
jschendel
added
Bug
Categorical
jschendel
reviewed
Aug 15, 2019
MarcoGorelli
force-pushed
the
categorical-fillna
branch
from
5b0e307 to
c089c45
Compare
MarcoGorelli
force-pushed
the
categorical-fillna
branch
from
c089c45 to
a679508
Compare
|
Looks great @MarcoGorelli. Thanks! |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 16, 2019
… only replaces null values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fillnausing columns of dtypecategoryalso fills non-NaN values #26215black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff