REF: use should_extension_dispatch for comparison method #27912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* BUG: fix Sparse reduction
jreback
requested changes
Aug 15, 2019
pandas/core/ops/__init__.py
Outdated
| @@ -605,14 +604,20 @@ def dispatch_to_extension_op(op, left, right): | |||
| new_right = extract_array(right, extract_numpy=True) | |||
|
|
|||
| try: | |||
| res_values = op(new_left, new_right) | |||
| with warnings.catch_warnings(): | |||
There was a problem hiding this comment.
can you add a comment on the condition on what this is filtering. can we pre-empt the DeprecationWarning by a check?
There was a problem hiding this comment.
turns out this was the wrong/suboptimal place to do this check. so this catch_warnings is now removed entirely and this is handled by checking for ABCExtensionArray before we get here
|
updated+green |
TomAugspurger
approved these changes
Aug 19, 2019
|
Thanks! |
EunSeop
pushed a commit
to EunSeop/pandas
that referenced
this pull request
Aug 20, 2019
…27912) * REF: implement should_extension_dispatch
galuhsahid
pushed a commit
to galuhsahid/pandas
that referenced
this pull request
Aug 25, 2019
…27912) * REF: implement should_extension_dispatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sits on top of #27815