Skip to content

REF: implement should_extension_dispatch #27815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 14, 2019
Merged

Conversation

jbrockmendel
Copy link
Member

This uses should_extension_dispatch in _arith_method_SERIES. We'll be able to use it in _comp_method_SERIES after #27803. (this is orthogonal to 27803 so doesn't matter what order they go in)

@gfyoung gfyoung added Refactor Internal refactoring of code Internals Related to non-user accessible pandas implementation labels Aug 9, 2019
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment otherwise lgtm.

@jreback jreback added this to the 1.0 milestone Aug 13, 2019
@jbrockmendel
Copy link
Member Author

Updated and green

@jbrockmendel
Copy link
Member Author

@jreback gentle ping; this is a step toward the Plan B discussed on the call for arithmetic perf

@jreback jreback merged commit 5c81d8a into pandas-dev:master Aug 14, 2019
@jreback
Copy link
Contributor

jreback commented Aug 14, 2019

thanks

@jbrockmendel jbrockmendel deleted the should branch August 14, 2019 21:34
quintusdias pushed a commit to quintusdias/pandas_dev that referenced this pull request Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internals Related to non-user accessible pandas implementation Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants