BUG: Avoid try/except in blocks, fix setitem bug in datetimelike EA #27704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Aug 2, 2019
| ], | ||
| ) | ||
| def test_setitem_objects(self, obj): | ||
| # make sure we accept datetime64 and datetime in addition to Timestamp |
There was a problem hiding this comment.
this is worth a release note?
There was a problem hiding this comment.
only affects the EAa, should't be user-facing
| @@ -418,7 +418,7 @@ def test_value_counts_unique_nunique_null(self, null_obj): | |||
| values = o._shallow_copy(v) | |||
| else: | |||
| o = o.copy() | |||
| o[0:2] = iNaT | |||
There was a problem hiding this comment.
what would happen to the arrange if you tried to assign iNaT? raise? coerce to object? do we have a test for that?
There was a problem hiding this comment.
coerce to object, and yes
jreback
added
Clean
Indexing
TomAugspurger
approved these changes
Aug 2, 2019
5 tasks
|
does this need rebase? as it included the just merged set indexing patch |
should be OK as is |
jreback
approved these changes
Aug 4, 2019
|
thanks |
quintusdias
pushed a commit
to quintusdias/pandas_dev
that referenced
this pull request
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial impetus for this was avoiding two try/excepts in Block methods (i.e. the diff in internals.blocks). This uncovered the bug in DTA/TDA, which accounts for the rest of the diff.