BUG: DTA/TDA incorrectly accepting iNaT for setitem #27699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TomAugspurger the Travis failure here seems to be affecting everything. The traceback looks like its somewhere in xdist or pytest. Didn't we recently deal with something really similar? |
|
Yeah, I think pytest 5.x is incompatible with pytest-xdist<=1.28
pytest 5.0.1 py36_0
pytest-forked 1.0.2 py36_0
pytest-mock 1.10.4 py36_0
pytest-xdist 1.28.0 py_0
So probably bump pytest-xdist>=1.29 in this env if possible.
…On Thu, Aug 1, 2019 at 2:08 PM jbrockmendel ***@***.***> wrote:
@TomAugspurger <https://github.com/TomAugspurger> the Travis failure here
seems to be affecting everything. The traceback looks like its somewhere in
xdist or pytest. Didn't we recently deal with something really similar?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#27699?email_source=notifications&email_token=AAKAOIS2SMCUAC7VNOT42NLQCMYCJA5CNFSM4IITHBW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3LS4RY#issuecomment-517418567>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKAOIUVGH6FUTXTORPDINDQCMYCJANCNFSM4IITHBWQ>
.
|
jreback
added
Indexing
|
green |
jreback
approved these changes
Aug 2, 2019
| @@ -418,7 +418,7 @@ def test_value_counts_unique_nunique_null(self, null_obj): | |||
| values = o._shallow_copy(v) | |||
| else: | |||
| o = o.copy() | |||
| o[0:2] = iNaT | |||
There was a problem hiding this comment.
same questions as #27704 (comment) (happy to do on either PR)
|
thanks |
quintusdias
pushed a commit
to quintusdias/pandas_dev
that referenced
this pull request
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffFirst of several related PRs.